Conversation
rtuck99
force-pushed
the
1950_wait_for_puck_and_pin
branch
from
f255836 to
4b80415
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1951 +/- ##
=======================================
Coverage 99.10% 99.10%
=======================================
Files 319 319
Lines 12230 12242 +12
=======================================
+ Hits 12121 12133 +12
Misses 109 109 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rtuck99
force-pushed
the
1950_wait_for_puck_and_pin
branch
from
4b80415 to
33812f7
Compare
rtuck99
changed the title
jacob720
approved these changes
Mar 18, 2026
Contributor
jacob720
left a comment
jacob720
left a comment
There was a problem hiding this comment.
Looks good, just one comment
tests/devices/test_bart_robot.py
Outdated
| _enable_beamline_and_update_pin, | ||
| _beamline_disable, | ||
| ) | ||
| # set_mock_value(bart_robot.beamline_disabled, BeamlineStatus.ENABLED.value) |
Contributor
There was a problem hiding this comment.
Should this comment be here?
Contributor
Author
There was a problem hiding this comment.
I will remove it, when we pick up the log message the side effect is now what enables the beamline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1950
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}